Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DISTINCT/ALL for aggregate functions #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support DISTINCT/ALL for aggregate functions #53

wants to merge 1 commit into from

Conversation

kendru
Copy link

@kendru kendru commented Jun 10, 2022

Fixes #52

  • Adds a Filter field to sqlast.Function that is an optional pointer to
    an "ALL" or "DISTINCT" identifier.
  • Attempts to parse DISTINCT/ALL before the argument list of a function
  • Adds a test to validate correct parsing.

@kendru
Support DISTINCT/ALL for aggregate functions
48f89c1 
- Adds a Filter field to sqlast.Function that is an optional pointer to
  an "ALL" or "DISTINCT" identifier.
- Attempts to parse DISTINCT/ALL before the argument list of a function
- Adds a test to validate correct parsing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot parse COUNT(DISTINCT ...)
1 participant
@kendru